reviews

Messages by Date

2020/07/07 Re: Review Request 72654: Added documentation for the TEARDOWN master call. Greg Mann
2020/07/07 Re: Review Request 72654: Added documentation for the TEARDOWN master call. Greg Mann
2020/07/07 Re: Review Request 72654: Added documentation for the TEARDOWN master call. Greg Mann
2020/07/07 Re: Review Request 72654: Added documentation for the TEARDOWN master call. Greg Mann
2020/07/07 Review Request 72654: Added documentation for the TEARDOWN master call. Greg Mann
2020/07/01 Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs. Mesos Reviewbot
2020/07/01 Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs. Andrei Sekretenko
2020/06/30 Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`. Mesos Reviewbot
2020/06/30 Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`. Benjamin Mahler
2020/06/30 Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`. Andrei Sekretenko
2020/06/29 [GitHub] [mesos] edi33416 commented on pull request #366: Fixed building on Windows with CMake 3.17+ GitBox
2020/06/29 [GitHub] [mesos] asekretenko commented on pull request #366: Fixed building on Windows with CMake 3.17+ GitBox
2020/06/29 [GitHub] [mesos] asfgit closed pull request #366: Fixed building on Windows with CMake 3.17+ GitBox
2020/06/27 Re: Review Request 72620: Deprecated tests plain text credential format. Dong Zhu
2020/06/26 Re: Review Request 72620: Deprecated tests plain text credential format. Mesos Reviewbot
2020/06/25 Review Request 72620: Deprecated tests plain text credential format. Dong Zhu
2020/06/25 Re: Review Request 72600: Remove credential text format support. Dong Zhu
2020/06/25 Review Request 72618: Deprecated tests plain text credential format. Dong Zhu
2020/06/25 Re: Review Request 72600: Remove credential text format support. Benjamin Mahler
2020/06/23 [GitHub] [mesos] edi33416 opened a new pull request #366: Fix Windows build issue generated by 3rdparty wclayer GitBox
2020/06/23 Re: Review Request 72600: Remove credential text format support. Mesos Reviewbot
2020/06/22 Re: Review Request 72600: Remove credential text format support. Dong Zhu
2020/06/22 Re: Review Request 72600: Remove credential text format support. Dong Zhu
2020/06/19 Re: Review Request 72600: Remove credential text format support. Benjamin Mahler
2020/06/16 Re: Review Request 72600: Remove credential text format support. Mesos Reviewbot
2020/06/16 Re: Review Request 72596: Added support of `null` values for syscall `args` in Seccomp. Qian Zhang
2020/06/16 Review Request 72600: Remove credential text format support. Dong Zhu
2020/06/16 Review Request 72596: Added support of `null` values for syscall `args` in Seccomp. Andrei Budnik
2020/06/16 Re: Review Request 72596: Added support of `null` values for syscall `args` in Seccomp. Mesos Reviewbot
2020/06/10 Re: Review Request 72575: Added URI to failure messages in URI fetcher plugins. Qian Zhang
2020/06/09 Re: Review Request 72575: Added URI to failure messages in URI fetcher plugins. Mesos Reviewbot
2020/06/09 Re: Review Request 72575: Added URI to failure messages in URI fetcher plugins. Andrei Budnik
2020/06/08 Re: Review Request 72575: Added URI to failure messages in URI fetcher plugins. Qian Zhang
2020/06/08 Re: Review Request 72575: Added URI to failure messages in URI fetcher plugins. Greg Mann
2020/06/08 Re: Review Request 72575: Added URI to failure messages in URI fetcher plugins. Mesos Reviewbot
2020/06/08 Review Request 72575: Added URI to failure messages in URI fetcher plugins. Andrei Budnik
2020/06/08 Re: Review Request 72448: Fixed operator api event inconsistencies issue. Dong Zhu
2020/06/02 Re: Review Request 72561: Added cmake install for missing build-time module dependencies. Mesos Reviewbot
2020/06/02 Re: Review Request 72561: Added cmake install for missing build-time module dependencies. Greg Mann
2020/06/02 Review Request 72561: Added cmake install for missing build-time module dependencies. Andrei Sekretenko
2020/05/29 Re: Review Request 72556: Fixed setting LIBPROCESS_ALLOW_JEMALLOC in Linux cmake build. Andrei Sekretenko
2020/05/29 Re: Review Request 72556: Fixed setting LIBPROCESS_ALLOW_JEMALLOC in Linux cmake build. Greg Mann
2020/05/29 Review Request 72556: Fixed setting LIBPROCESS_ALLOW_JEMALLOC in Linux cmake build. Andrei Sekretenko
2020/05/29 [GitHub] [mesos] asfgit closed pull request #363: CMake enable install module dependencies. GitBox
2020/05/29 [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/28 [GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/28 Re: Review Request 72492: Introduced install target into cmake build. Greg Mann
2020/05/27 Re: Review Request 72536: Added documentation for installing mesos-tests. Greg Mann
2020/05/27 Re: Review Request 72494: Added tests to cmake install target. Greg Mann
2020/05/27 Re: Review Request 72493: Added install target into libprocess cmake build. Greg Mann
2020/05/27 Re: Review Request 72492: Introduced install target into cmake build. Greg Mann
2020/05/27 Re: Review Request 72535: Added documentation for the cmake install target. Greg Mann
2020/05/27 Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs. Andrei Sekretenko
2020/05/27 Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs. Benjamin Mahler
2020/05/27 Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`. Benjamin Mahler
2020/05/27 Re: Review Request 72536: Added documentation for installing mesos-tests. Andrei Sekretenko
2020/05/27 Re: Review Request 72535: Added documentation for the cmake install target. Andrei Sekretenko
2020/05/27 Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`. Andrei Sekretenko
2020/05/27 Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs. Andrei Sekretenko
2020/05/27 Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`. Mesos Reviewbot
2020/05/27 Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs. Mesos Reviewbot
2020/05/27 Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`. Andrei Sekretenko
2020/05/27 Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs. Andrei Sekretenko
2020/05/27 Review Request 72547: Fixed missing protoc dependency of compiled protobufs. Andrei Sekretenko
2020/05/26 Re: Review Request 72523: Added a test `ROOT_CommandTaskNoRootfsWithUnmountVolumeFailure`. Andrei Budnik
2020/05/26 Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator. Andrei Budnik
2020/05/25 Re: Review Request 72523: Added a test `ROOT_CommandTaskNoRootfsWithUnmountVolumeFailure`. Mesos Reviewbot
2020/05/25 Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator. Qian Zhang
2020/05/25 Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator. Qian Zhang
2020/05/25 Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator. Andrei Budnik
2020/05/25 [GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/25 [GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/25 [GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/22 [GitHub] [mesos] Digital-Chaos commented on pull request #365: Fix FreeBSD memory detection (MESOS-10104) GitBox
2020/05/21 [GitHub] [mesos] Digital-Chaos edited a comment on pull request #365: Fix FreeBSD memory detection (MESOS-10104) GitBox
2020/05/20 [GitHub] [mesos] bmahler closed pull request #365: Fix FreeBSD memory detection (MESOS-10104) GitBox
2020/05/20 [GitHub] [mesos] bmahler commented on pull request #365: Fix FreeBSD memory detection (MESOS-10104) GitBox
2020/05/20 Review Request 72536: Added an example to illustarate installing mesos-tests. Andrei Sekretenko
2020/05/20 Re: Review Request 72494: Added tests to cmake install target. Andrei Sekretenko
2020/05/20 Re: Review Request 72493: Added install target into libprocess cmake build. Andrei Sekretenko
2020/05/20 Re: Review Request 72493: Added install target into libprocess cmake build. Andrei Sekretenko
2020/05/20 Review Request 72535: Added a usage example for cmake install target into docs. Andrei Sekretenko
2020/05/20 Re: Review Request 72492: Introduced install target into cmake build. Andrei Sekretenko
2020/05/20 Re: Review Request 72492: Introduced install target into cmake build. Andrei Sekretenko
2020/05/20 Re: Review Request 72492: Introduced install target into cmake build. Andrei Sekretenko
2020/05/20 Re: Review Request 72492: Introduced install target into cmake build. Andrei Sekretenko
2020/05/19 [GitHub] [mesos] Digital-Chaos edited a comment on pull request #365: Fix FreeBSD memory detection (MESOS-10104) GitBox
2020/05/19 [GitHub] [mesos] Digital-Chaos edited a comment on pull request #365: Fix FreeBSD memory detection (MESOS-10104) GitBox
2020/05/19 [GitHub] [mesos] Digital-Chaos commented on pull request #365: Fix FreeBSD memory detection (MESOS-10104) GitBox
2020/05/19 Re: Review Request 72492: Introduced install target into cmake build. Greg Mann
2020/05/19 [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/19 [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/19 [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/19 [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/19 [GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/18 [GitHub] [mesos] bmahler commented on pull request #365: Fix FreeBSD memory detection (MESOS-10104) GitBox
2020/05/18 Re: Review Request 71300: Removed mesos-style transition script. Benjamin Bannier
2020/05/17 Re: Review Request 72523: Added a test `ROOT_CommandTaskNoRootfsWithUnmountVolumeFailure`. Mesos Reviewbot
2020/05/17 Review Request 72523: Added a test `ROOT_CommandTaskNoRootfsWithUnmountVolumeFailure`. Qian Zhang
2020/05/17 [GitHub] [mesos] Digital-Chaos opened a new pull request #365: Fix FreeBSD memory detection (MESOS-10104) GitBox
2020/05/17 [GitHub] [mesos] csaltos commented on pull request #364: MESOS-10129 Build fails on Maven javadoc generation when using JDK11 GitBox
2020/05/17 [GitHub] [mesos] csaltos opened a new pull request #364: Fixing Java doc for JDK11 GitBox
2020/05/15 Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator. Mesos Reviewbot
2020/05/15 Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator. Qian Zhang
2020/05/15 [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/14 Re: Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree. Mesos Reviewbot
2020/05/14 Re: Review Request 72508: Fixed performance of tracking resource totals in allocator's roles tree. Andrei Sekretenko
2020/05/14 Re: Review Request 72508: Fixed performance of tracking resource totals in allocator's roles tree. Benjamin Mahler
2020/05/14 Re: Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree. Benjamin Mahler
2020/05/14 [GitHub] [mesos] greggomann commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/14 Re: Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree. Andrei Sekretenko
2020/05/14 [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/14 [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/14 [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/13 [GitHub] [mesos] greggomann commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/13 Re: Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree. Mesos Reviewbot
2020/05/13 Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree. Andrei Sekretenko
2020/05/13 Review Request 72508: Fixed performance of tracking resource totals in allocator's roles tree. Andrei Sekretenko
2020/05/13 [GitHub] [mesos] greggomann commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/13 Re: Review Request 72492: Introduced install target into cmake build. Greg Mann
2020/05/13 [GitHub] [mesos] greggomann commented on a change in pull request #363: CMake enable install module dependencies. GitBox
2020/05/12 Re: Review Request 72495: Added Web UI install target. Greg Mann
2020/05/12 Re: Review Request 72494: Added tests to cmake install target. Greg Mann
2020/05/11 Re: Review Request 72493: Added install target into libprocess cmake build. Greg Mann
2020/05/11 Re: Review Request 72492: Introduced install target into cmake build. Greg Mann
2020/05/11 Re: Review Request 72496: Added install targets for Java libraries. Mesos Reviewbot
2020/05/11 Review Request 72494: Added tests to cmake install target. Andrei Sekretenko
2020/05/11 Review Request 72492: Introduced install target into cmake build. Andrei Sekretenko
2020/05/11 Review Request 72493: Added install target into libprocess cmake build. Andrei Sekretenko
2020/05/11 Review Request 72496: Added install targets for Java libraries. Andrei Sekretenko
2020/05/11 Review Request 72495: Added Web UI install target. Andrei Sekretenko
2020/05/07 [GitHub] [mesos] cf-natali commented on pull request #362: Keep retrying to remove cgroup on EBUSY. GitBox
2020/05/07 Re: Review Request 72478: Changed permissions for domain sockets to allow non-root executors. Qian Zhang
2020/05/07 [GitHub] [mesos] cf-natali commented on a change in pull request #362: Keep retrying to remove cgroup on EBUSY. GitBox
2020/05/07 [GitHub] [mesos] cf-natali commented on a change in pull request #362: Keep retrying to remove cgroup on EBUSY. GitBox
2020/05/06 Re: Review Request 72410: Updated existing documentation for resource limits. Qian Zhang
2020/05/06 Re: Review Request 72475: Logged connection error message before shutting down the executor. Qian Zhang
2020/05/06 Re: Review Request 72410: Updated existing documentation for resource limits. Greg Mann
2020/05/06 Re: Review Request 72410: Updated existing documentation for resource limits. Greg Mann
2020/05/06 [GitHub] [mesos] cf-natali commented on pull request #362: Keep retrying to remove cgroup on EBUSY. GitBox
2020/05/06 [GitHub] [mesos] vinodkone commented on pull request #362: Keep retrying to remove cgroup on EBUSY. GitBox
2020/05/06 [GitHub] [mesos] cf-natali commented on pull request #362: Keep retrying to remove cgroup on EBUSY. GitBox
2020/05/06 Re: Review Request 72478: Changed permissions for domain sockets to allow non-root executors. Mesos Reviewbot
2020/05/06 Review Request 72478: Changed permissions for domain sockets to allow non-root executors. Andrei Budnik
2020/05/06 Re: Review Request 72475: Logged connection error message before shutting down the executor. Andrei Budnik
2020/05/06 Re: Review Request 71300: Removed mesos-style transition script. Andrei Sekretenko
2020/05/06 Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call. Andrei Sekretenko
2020/05/06 Re: Review Request 72475: Added log message in executor's `disconnected` method before shutdown. Mesos Reviewbot
2020/05/06 Review Request 72475: Added log message in executor's `disconnected` method before shutdown. Andrei Budnik
2020/05/05 Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call. Mesos Reviewbot
2020/05/05 Re: Review Request 72368: Fixed a bug in the agent's draining handler. Greg Mann
2020/05/05 Re: Review Request 72473: Fixed src/Makefile.am to include Web UI roles tree files. Mesos Reviewbot
2020/05/05 Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call. Benjamin Mahler
2020/05/05 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Mesos Reviewbot
2020/05/05 Re: Review Request 72473: Fixed src/Makefile.am to include Web UI roles tree files. Benjamin Mahler
2020/05/05 Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call. Andrei Sekretenko
2020/05/05 Review Request 72473: Fixed src/Makefile.am to include Web UI roles tree files. Andrei Sekretenko
2020/05/05 Re: Review Request 72368: Fixed a bug in the agent's draining handler. Andrei Sekretenko
2020/05/05 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Greg Mann
2020/05/05 Re: Review Request 72368: Fixed a bug in the agent's draining handler. Greg Mann
2020/05/05 Re: Review Request 72368: Fixed a bug in the agent's draining handler. Greg Mann
2020/05/05 Re: Review Request 72368: Fixed a bug in the agent's draining handler. Greg Mann
2020/05/05 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Andrei Sekretenko
2020/05/05 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Mesos Reviewbot
2020/05/05 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Andrei Sekretenko
2020/05/05 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Andrei Sekretenko
2020/05/05 Re: Review Request 72368: Fixed a bug in the agent's draining handler. Andrei Sekretenko
2020/05/05 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Mesos Reviewbot
2020/05/05 Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits. Qian Zhang
2020/05/05 Re: Review Request 72305: Sent appropriate task status reason when task over memory request. Qian Zhang
2020/05/05 Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`. Qian Zhang
2020/05/05 Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`. Qian Zhang
2020/05/04 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Greg Mann
2020/05/04 Re: Review Request 72368: Fixed a bug in the agent's draining handler. Greg Mann
2020/05/04 Re: Review Request 72368: Fixed a bug in the agent's draining handler. Greg Mann
2020/05/04 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Mesos Reviewbot
2020/05/04 Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits. Greg Mann
2020/05/04 Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`. Greg Mann
2020/05/04 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Andrei Sekretenko
2020/05/04 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Mesos Reviewbot
2020/05/04 Re: Review Request 72363: Fixed handling disconnected agents by REACTIVATE_AGENT call. Andrei Sekretenko
2020/05/04 Re: Review Request 72364: Added test for reactivation of a disconnected drained agent. Andrei Sekretenko
2020/05/02 Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`. Andrei Budnik
2020/05/01 [GitHub] [mesos] cf-natali opened a new pull request #362: Keep retrying to remove cgroup on EBUSY. GitBox
2020/05/01 Re: Review Request 72461: WIP: Fixed cmd.exe handling in Subprocess. Mesos Reviewbot
2020/05/01 Review Request 72461: WIP: Fixed cmd.exe handling in Subprocess. Benjamin Mahler
2020/05/01 Review Request 72460: WIP: Fixed Windows cmd.exe handling in stout's shell.hpp. Benjamin Mahler
2020/05/01 Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits. Mesos Reviewbot
2020/05/01 Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits. Qian Zhang
2020/05/01 Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits. Qian Zhang
2020/05/01 Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits. Greg Mann
2020/05/01 Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits. Greg Mann
2020/04/30 Re: Review Request 72303: Moved documentation into os/exec.hpp interface. Greg Mann
2020/04/30 Re: Review Request 72456: Removed unecessary os::execlp wrapper. Greg Mann
2020/04/30 Re: Review Request 72304: Moved documentation into os/shell.hpp interface. Mesos Reviewbot
2020/04/30 Re: Review Request 72303: Moved documentation into os/exec.hpp interface. Benjamin Mahler
2020/04/30 Review Request 72456: Removed unecessary os::execlp wrapper. Benjamin Mahler
2020/04/30 Re: Review Request 72304: Moved documentation into os/shell.hpp interface. Greg Mann
2020/04/30 Re: Review Request 72401: Updated Docker containerizer by not updating resources for command task. Greg Mann
2020/04/29 Re: Review Request 72448: Fixed operator api event inconsistencies issue. Dong Zhu