----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50498/#review150974 -----------------------------------------------------------
src/master/flags.cpp (line 561) <https://reviews.apache.org/r/50498/#comment219078> How about `--master_pid_group` instead? (All of the flags will have the same length and style :) - Joseph Wu On Aug. 5, 2016, 1:28 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50498/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2016, 1:28 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5829 > https://issues.apache.org/jira/browse/MESOS-5829 > > > Repository: mesos > > > Description > ------- > > Added --pid_group flag to pass in pid_group module name. Necessary > validation logic is added to master/main.cpp. > > > Diffs > ----- > > src/master/flags.hpp c6e85303f60387f42b5e187eaedb6a01000f948f > src/master/flags.cpp 19ae6c1c30a1054b64a9585f325bd0bf943af218 > src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e > > Diff: https://reviews.apache.org/r/50498/diff/ > > > Testing > ------- > > see end of review chain. > > > Thanks, > > Jay Guo > >
