----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50493/#review150971 -----------------------------------------------------------
3rdparty/libprocess/include/process/pid_group.hpp (lines 54 - 59) <https://reviews.apache.org/r/50493/#comment219074> We shouldn't have two ways of specifying the `base` PIDs. Let's remove the `base` from the constructor in favor of runtime initialization. 3rdparty/libprocess/include/process/pid_group.hpp (line 59) <https://reviews.apache.org/r/50493/#comment219076> Does this need to be a virtual function? e.g. Is there anything the module needs to do here that can't be done during construction or while being used by the replicated log? 3rdparty/libprocess/src/pid_group.cpp (lines 182 - 185) <https://reviews.apache.org/r/50493/#comment219075> This shouldn't be a no-op (especially based on the above). - Joseph Wu On Aug. 5, 2016, 1:18 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50493/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2016, 1:18 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5828 > https://issues.apache.org/jira/browse/MESOS-5828 > > > Repository: mesos > > > Description > ------- > > All subclasses derived from PIDGroup are required to have `base` > as a set of PIDs that always exist from the beginning. Therefore > `base` is refactored into PIDGroup base class. This is a step > towards modularizing replicated_log's PIDGroup abstraction. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/pid_group.hpp PRE-CREATION > 3rdparty/libprocess/src/pid_group.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/50493/diff/ > > > Testing > ------- > > see end of review chain > > > Thanks, > > Jay Guo > >
