> On Sept. 28, 2016, 8:11 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 278-298 > > <https://reviews.apache.org/r/52010/diff/2/?file=1511506#file1511506line278> > > > > This is not correct, if we do that, we'll break Docker containerizer. > > Please see the comments in the original code. > > Gilbert Song wrote: > This is only for nested containers. We dont have nested containers in > docker containerizer, right?
ah, you're right! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52010/#review150753 ----------------------------------------------------------- On Sept. 28, 2016, 5:49 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52010/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 5:49 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-6191 > https://issues.apache.org/jira/browse/MESOS-6191 > > > Repository: mesos > > > Description > ------- > > Supported filesystem linux isolator to be nested aware. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.hpp > 0a85935550e36c9142d845465cfa70a1634a647a > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > ea418252956c8089acc5a491888ed7f6df6cafcd > > Diff: https://reviews.apache.org/r/52010/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
