----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52010/#review149394 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 245) <https://reviews.apache.org/r/52010/#comment216996> I think we can still call parseExecutorRunPath first. Then, we can call parseContainerPath (in containerizer paths.hpp) to get the containerId src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 255 - 259) <https://reviews.apache.org/r/52010/#comment216998> I think we should deal with unknown orphans for nested container, but not top level container (because it might belong to DockerContainerizer). So if the container is a nested container, we still create Info for unkonwn orphan and call cleanup immediately after. src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 293 - 300) <https://reviews.apache.org/r/52010/#comment217000> Hum, we should enforce that in containerizer, rather than doing this check everywhere. Can we make sure, in containerizer, that if a parent container is being destroyed (state == DESTROYING), no child container can be launched? src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 331 - 334) <https://reviews.apache.org/r/52010/#comment217001> This does not sound right, we could have persistent volumes for nested container as well. - Jie Yu On Sept. 18, 2016, 5:31 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52010/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2016, 5:31 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-6191 > https://issues.apache.org/jira/browse/MESOS-6191 > > > Repository: mesos > > > Description > ------- > > Supported filesystem linux isolator to be nested aware. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.hpp > 0a85935550e36c9142d845465cfa70a1634a647a > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > ea418252956c8089acc5a491888ed7f6df6cafcd > > Diff: https://reviews.apache.org/r/52010/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
