----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51407/#review150324 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/containerizer.cpp (lines 897 - 914) <https://reviews.apache.org/r/51407/#comment218264> I'd move this up before we actually put 'Container' struct to `containers_` map. The reason being if `mkdir` fails, we don't leave a container struct in the map. That can speed up the cleanup. src/slave/containerizer/mesos/containerizer.cpp (lines 1885 - 1886) <https://reviews.apache.org/r/51407/#comment218263> It's likely that runtimePath does not exist because it is a legacy container. In that case, we should just ignore it. src/slave/containerizer/mesos/containerizer.cpp (line 1890) <https://reviews.apache.org/r/51407/#comment218262> Please log the error message as well. - Jie Yu On Sept. 24, 2016, 8:20 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51407/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2016, 8:20 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6204 > https://issues.apache.org/jira/browse/MESOS-6204 > > > Repository: mesos > > > Description > ------- > > This includes checkpointing both the container pid and the status of > the container upon exit. This also includes an update to tests to > account for new 'init' process semantics in a container. That is, the > name of the init process of the container is now "mesos-containerizer" > not "sh". > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 16f9e3e92e90fe7f8a0ebd24e567800e1f285bc9 > src/slave/containerizer/mesos/containerizer.cpp > ed3089a089128e712c4a95e7b5842e9c2abacbb5 > src/tests/containerizer/isolator_tests.cpp > b4d25e57df7f0e157769c9ae4f7847657c505e78 > > Diff: https://reviews.apache.org/r/51407/diff/ > > > Testing > ------- > > $ GTEST_FILTER="" make -j check > $ src/mesos-tests > $ sudo src/mesos-tests > > > Thanks, > > Kevin Klues > >
