> On Sept. 24, 2016, 1:50 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1340-1346 > > <https://reviews.apache.org/r/51407/diff/7/?file=1509433#file1509433line1340> > > > > Let's avoid checkpoint the pid for legacy container (i.e., those > > containers whose runtime dir does not exist). See my comments last time.
I don't understand this comment. This checkpionting is being done in the `launch()` path. How could we be checkpointing for a legacy container if we are launching a new container? > On Sept. 24, 2016, 1:50 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1888 > > <https://reviews.apache.org/r/51407/diff/7/?file=1509433#file1509433line1888> > > > > This should be LOG(ERROR) or LOG(WARNING)? > > > > I think for legacy container case, we should do a exists check and if > > exists, LOG(ERROR) if we fail to remove it. Yeah, I think this tech debt copied from somewhere else. I'll change it to a LOG(WARNING). - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51407/#review150282 ----------------------------------------------------------- On Sept. 23, 2016, 9:01 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51407/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 9:01 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6204 > https://issues.apache.org/jira/browse/MESOS-6204 > > > Repository: mesos > > > Description > ------- > > This includes checkpointing both the container pid and the status of > the container upon exit. This also includes an update to tests to > account for new 'init' process semantics in a container. That is, the > name of the init process of the container is now "mesos-containerizer" > not "sh". > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 16f9e3e92e90fe7f8a0ebd24e567800e1f285bc9 > src/slave/containerizer/mesos/containerizer.cpp > 144b0db501d40d4e0bba12672723616bedd76e7e > src/tests/containerizer/isolator_tests.cpp > b4d25e57df7f0e157769c9ae4f7847657c505e78 > > Diff: https://reviews.apache.org/r/51407/diff/ > > > Testing > ------- > > $ GTEST_FILTER="" make -j check > $ src/mesos-tests > $ sudo src/mesos-tests > > > Thanks, > > Kevin Klues > >
