----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review149695 -----------------------------------------------------------
Patch looks great! Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 50702, 50703, 50704, 50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 51374, 51375, 51376, 51377, 51021, 51706, 51653, 51707, 51805, 51845, 51891, 51909, 51913, 51953, 51954, 51955, 51956, 51957, 51958, 52039, 52083] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 20, 2016, 3:26 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52083/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 3:26 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6206 > https://issues.apache.org/jira/browse/MESOS-6206 > > > Repository: mesos > > > Description > ------- > > Previously, explicit reconciliation for an agent that was in the process > of reregistering or unregistering returned no results. This degree of > cleverness seems unwarranted: if the agent hasn't completed the > reregistration or unregistration process, it seems quite reasonable for > the master to return the previous state of the agent (this is what the > framework would observe if their reconcile request lost the race with > the reregister/unregister, anyway). > > Note that since reregistering agents are no longer considered to be "in > transition", we need to slightly adjust the rules for how we update the > `slaves.recovered` collection in the master: an agent remains in the > "recovered" collection until it has been marked reachable in the > registry (rather than removing it from "recovered" as soon as the > reregistration process beings). This is more consistent with how we > manage the other collections in the master anyway. > > > Diffs > ----- > > src/master/master.hpp 35db198748b8652eb53e17f592f6b40d1e6a3ed9 > src/master/master.cpp 66a672f6d16233e96b29e330a9e6c474546fa851 > src/tests/master_tests.cpp e6c8362da6a5669e2a2d18f6eb4e454365a84f60 > src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a > > Diff: https://reviews.apache.org/r/52083/diff/ > > > Testing > ------- > > `make check` on OSX, Linux. > > > Thanks, > > Neil Conway > >
