----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149611 -----------------------------------------------------------
src/common/resources.cpp (line 613) <https://reviews.apache.org/r/52001/#comment217267> Not yours, but I prefer that we quota token as ``` "Bad value for resources, missing or extra ':' in '" + token + "'"); ``` src/common/resources.cpp (lines 633 - 634) <https://reviews.apache.org/r/52001/#comment217268> I prefer that we quota `key` and `token` ``` return Error( "Bad value for resources, mismatched brackets in '" + key + "' for '" + token + "'"); ``` Ditto for others src/common/resources.cpp (line 700) <https://reviews.apache.org/r/52001/#comment217269> What about adding `UNREACHABLE()` here? - Guangya Liu On 九月 19, 2016, 10:43 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52001/ > ----------------------------------------------------------- > > (Updated 九月 19, 2016, 10:43 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6062 > https://issues.apache.org/jira/browse/MESOS-6062 > > > Repository: mesos > > > Description > ------- > > Text based representation of disk resources can indicate source type > (ie. PATH or MOUNT) and its root. This makes it closer to the JSON > representation. > > > Diffs > ----- > > src/common/resources.cpp 4602bff22ec7ff77f069056085ad92bfa04595f3 > src/v1/resources.cpp 7c4db44d4c31a8295cc16b0ce1ef5adf314e6ac6 > > Diff: https://reviews.apache.org/r/52001/diff/ > > > Testing > ------- > > > Thanks, > > Anindya Sinha > >
