----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149490 -----------------------------------------------------------
src/common/resources.cpp (lines 616 - 648) <https://reviews.apache.org/r/52001/#comment217141> This is conflict with range resources `ports:[21000-24000,30000-34000]`. src/common/resources.cpp (line 617) <https://reviews.apache.org/r/52001/#comment217139> use `back()` instead of `[xx.size() - 1]` src/common/resources.cpp (lines 680 - 693) <https://reviews.apache.org/r/52001/#comment217140> Use `Resource::DiskInfo::Source::Type_Parse` instead. - haosdent huang On Sept. 19, 2016, 5:01 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52001/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 5:01 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6062 > https://issues.apache.org/jira/browse/MESOS-6062 > > > Repository: mesos > > > Description > ------- > > Text based representation of disk resources can indicate source type > (ie. PATH or MOUNT) and its root. This makes it closer to the JSON > representation. > > > Diffs > ----- > > src/common/resources.cpp 4602bff22ec7ff77f069056085ad92bfa04595f3 > src/v1/resources.cpp 7c4db44d4c31a8295cc16b0ce1ef5adf314e6ac6 > > Diff: https://reviews.apache.org/r/52001/diff/ > > > Testing > ------- > > > Thanks, > > Anindya Sinha > >
