> On Sept. 16, 2016, 7:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 509-514 > > <https://reviews.apache.org/r/51965/diff/2/?file=1500312#file1500312line509> > > > > Can we factor out this into a helper in > > `src/slave/containerizer/mesos/utils.hpp`. I imagine a lot of isolator will > > use that. > > Kevin Klues wrote: > Sure. Any recommendations on a name?
how about `getRootContainerId` - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51965/#review149244 ----------------------------------------------------------- On Sept. 16, 2016, 7:10 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51965/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2016, 7:10 p.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Bugs: MESOS-6186 > https://issues.apache.org/jira/browse/MESOS-6186 > > > Repository: mesos > > > Description > ------- > > Updated the generic 'cgroups' isolator to be nested container aware. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > e87d055a44041735b62afd94aebcedf0f38a71bb > > Diff: https://reviews.apache.org/r/51965/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Kevin Klues > >
