> On Sept. 16, 2016, 7:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 372 > > <https://reviews.apache.org/r/51965/diff/2/?file=1500312#file1500312line372> > > > > does this compile?
No :/ I pushed it prematurely after running the tests, but then adding this afterwards. > On Sept. 16, 2016, 7:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 538 > > <https://reviews.apache.org/r/51965/diff/2/?file=1500312#file1500312line538> > > > > WHy not just short circuit above the for loop? Yeah, that's more along the lines of what I meant to do. For some reason I was thinking we were looping through a bunch of containers here and needed to filter out nested ones. But we are working on *one* container and just looping through subsystems. > On Sept. 16, 2016, 7:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 509-514 > > <https://reviews.apache.org/r/51965/diff/2/?file=1500312#file1500312line509> > > > > Can we factor out this into a helper in > > `src/slave/containerizer/mesos/utils.hpp`. I imagine a lot of isolator will > > use that. Sure. Any recommendations on a name? - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51965/#review149244 ----------------------------------------------------------- On Sept. 16, 2016, 7:10 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51965/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2016, 7:10 p.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Bugs: MESOS-6186 > https://issues.apache.org/jira/browse/MESOS-6186 > > > Repository: mesos > > > Description > ------- > > Updated the generic 'cgroups' isolator to be nested container aware. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > e87d055a44041735b62afd94aebcedf0f38a71bb > > Diff: https://reviews.apache.org/r/51965/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Kevin Klues > >
