----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51784/#review148413 -----------------------------------------------------------
Patch looks great! Reviews applied: [51784] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 11, 2016, 12:17 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51784/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2016, 12:17 a.m.) > > > Review request for mesos, Benjamin Bannier and Gilbert Song. > > > Bugs: MESOS-5275 > https://issues.apache.org/jira/browse/MESOS-5275 > > > Repository: mesos > > > Description > ------- > > Previously, we only allow one isolator to specify the launch command > for the container. This is not ideal because multiple isolators might > want to add some flags to the command executor. For instance, the > 'docker/runtime' isolator wants to specify '--task_command' and > '--working_directory', and 'linux/capabilities' isolator wants to > specify '--capabilities'. > > This patch changes the semantics so that launch command from isolators > are merged. However, it is isolator's responsibility to make sure the > merged command is a valid command. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 89b7e8db38916d69d9b2d4fe305d4397b0859a10 > > Diff: https://reviews.apache.org/r/51784/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
