> On May 26, 2016, 9:12 p.m., Greg Mann wrote: > > src/master/master.cpp, line 3742 > > <https://reviews.apache.org/r/47515/diff/2/?file=1391192#file1391192line3742> > > > > What about just `None()` here?
We actually can't use `None()` here, since the second operand of the `?` operator is a `std::string`. One of the second and third operands must be convertible into the other, so we use an `Option<string>` here. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47515/#review135064 ----------------------------------------------------------- On May 27, 2016, 4:32 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47515/ > ----------------------------------------------------------- > > (Updated May 27, 2016, 4:32 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. > > > Bugs: MESOS-5005 > https://issues.apache.org/jira/browse/MESOS-5005 > > > Repository: mesos > > > Description > ------- > > This patch enforces the constraint that the principal > found in `DiskInfo.Persistence` should equal that of > the framework or operator responsible for creating > the volume. > > > Diffs > ----- > > src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 > src/master/master.cpp 0005a29caabcc6a3776037cf86a2b12660e6377b > src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 > src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 > > Diff: https://reviews.apache.org/r/47515/diff/ > > > Testing > ------- > > `make check` was used to test on OSX at the end of this review chain. > > > Thanks, > > Greg Mann > >
