----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47515/#review133744 -----------------------------------------------------------
src/master/master.cpp (line 3750) <https://reviews.apache.org/r/47515/#comment198337> Although there does not seem to be a rule in the style guide for this, I'd suggest: {code} Option<string> principal = framework->info.has_principal() ? framework->info.principal() : Option<string>::none(); {code} src/master/validation.cpp (line 823) <https://reviews.apache.org/r/47515/#comment198335> was -> has been same below - Bernd Mathiske On May 18, 2016, 1:01 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47515/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 1:01 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. > > > Bugs: MESOS-5005 > https://issues.apache.org/jira/browse/MESOS-5005 > > > Repository: mesos > > > Description > ------- > > This patch enforces the constraint that the principal > found in `DiskInfo.Persistence` should equal that of > the framework or operator responsible for creating > the volume. > > > Diffs > ----- > > src/master/http.cpp c4ca343baa318fbb05ba2cbc3ed892c16478dbcc > src/master/master.cpp b8c732a6178777544f0d09708177d9c68ab0532b > src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 > src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 > > Diff: https://reviews.apache.org/r/47515/diff/ > > > Testing > ------- > > `make check` was used to test on OSX at the end of this review chain. > > > Thanks, > > Greg Mann > >
