----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/#review131462 -----------------------------------------------------------
include/mesos/resources.hpp (line 167) <https://reviews.apache.org/r/45960/#comment195460> s/isShareable/isShared/ include/mesos/resources.hpp (lines 314 - 317) <https://reviews.apache.org/r/45960/#comment197804> We don't need this. As dicussed offline, whether destroying a volume is allowed is determined by the master and not the resources abstraction. include/mesos/resources.hpp (line 343) <https://reviews.apache.org/r/45960/#comment195462> s/shareable/shared/ include/mesos/resources.hpp (line 345) <https://reviews.apache.org/r/45960/#comment195461> I know it's mirroring the comments for nonRevocable() but it feels a little strange as the API returns a Resouces object and not a bool. Just ``` // Returns the non-shared resources. ``` would be fine. include/mesos/resources.hpp (line 346) <https://reviews.apache.org/r/45960/#comment197806> s/nonShareable/nonshared/. src/common/resources.cpp (line 370) <https://reviews.apache.org/r/45960/#comment195463> s/ShareInfo/SharedInfo/ src/common/resources.cpp (line 750) <https://reviews.apache.org/r/45960/#comment195464> I like the use of `shareability` here. ;) src/common/resources.cpp (lines 760 - 761) <https://reviews.apache.org/r/45960/#comment195465> This fits in one line. src/common/resources.cpp (line 835) <https://reviews.apache.org/r/45960/#comment197809> Why the extra `()`? - Jiang Yan Xu On April 28, 2016, 5:16 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45960/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 5:16 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4431 > https://issues.apache.org/jira/browse/MESOS-4431 > > > Repository: mesos > > > Description > ------- > > Added interfaces to handle and track shareable resources. > > > Diffs > ----- > > include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 > include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 > src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 > src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a > > Diff: https://reviews.apache.org/r/45960/diff/ > > > Testing > ------- > > Tests successful. > > > Thanks, > > Anindya Sinha > >
