----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/#review132180 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/windows/winsock.hpp (line 40) <https://reviews.apache.org/r/46344/#comment196347> Capture by reference, just don't store it by reference. - Joris Van Remoortere On April 23, 2016, 9:50 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46344/ > ----------------------------------------------------------- > > (Updated April 23, 2016, 9:50 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3656 > https://issues.apache.org/jira/browse/MESOS-3656 > > > Repository: mesos > > > Description > ------- > > Libprocess: Created Winsock class to handle WSAStartup/WSACleanup. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > 47f5347988a61140c87bcd329e25d5a4d52e17a0 > 3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46344/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
