----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review129450 -----------------------------------------------------------
src/authorizer/local/authorizer.cpp (line 204) <https://reviews.apache.org/r/45342/#comment192864> We generally avoid 'default' cases in enum switches because they allow the code to compile when a new enum value is introduced. If you use a 'case UNKNOWN' instead, this will handle the unknown types and will prevent the code from compiling when a new enum value is introduced but not handled. Make sense? Ditto for the recent executor.proto and scheduler.proto changes. - Ben Mahler On March 29, 2016, 2:04 a.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45342/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 2:04 a.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. > > > Bugs: MESOS-5031 > https://issues.apache.org/jira/browse/MESOS-5031 > > > Repository: mesos > > > Description > ------- > > This fix tries to make the Action enum in Authorization optional > to support upgrades. See MESOS-4997 for details. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto > 944a493e0979c7ffbd99f3a67785a10425fd9040 > src/authorizer/local/authorizer.cpp > 0f0d9276337858984f0b19a82ffca74ee84dc650 > > Diff: https://reviews.apache.org/r/45342/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
