> On 三月 15, 2016, 7:42 a.m., haosdent huang wrote: > > And seems don't contains `appc` part in this patch?
AppC will be handled in the following patch. > On 三月 15, 2016, 7:42 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, line 188 > > <https://reviews.apache.org/r/44838/diff/1/?file=1299389#file1299389line188> > > > > Because we don't set default value of `force_pull_image` in protobuf > > file. Seems here would be `false`. It is a excepted behaviour, right? Yes, there is already a similar parameter here https://reviews.apache.org/r/28190 for docker containerizer, I was using similar logic to handle it in mesos containerizer. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review123614 ----------------------------------------------------------- On 三月 15, 2016, 7:18 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44838/ > ----------------------------------------------------------- > > (Updated 三月 15, 2016, 7:18 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4886 > https://issues.apache.org/jira/browse/MESOS-4886 > > > Repository: mesos > > > Description > ------- > > Enabled mesos containerizer force_pull_image for docker. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp > 137af502a66e6a65773c00eaacbe392576376284 > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp > cf630cc0b67a325529fa04ad2b1708e013b9596a > src/slave/containerizer/mesos/provisioner/docker/store.cpp > eeec94326a4fd67675df10e0b6a32267e555fa96 > > Diff: https://reviews.apache.org/r/44838/diff/ > > > Testing > ------- > > make > make check > > It is difficult to test this with unit test, but just test with mesos execute > by setting `force_pull_image` as true and found that the iamge was always > pulled when `force_pull_image` is true. > > > Thanks, > > Guangya Liu > >
