----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review123612 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp (line 93) <https://reviews.apache.org/r/44838/#comment185848> Should we have default value for `forcePullImage`, for example: `forcePullImage=false`. src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 167) <https://reviews.apache.org/r/44838/#comment185850> Maybe we need log `forcePullImage` option in this log item. src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 169) <https://reviews.apache.org/r/44838/#comment185849> I suggest change ``` !storedImages.contains(imageReference) || forcePullImage ``` to ``` forcePullImage || !storedImages.contains(imageReference) ``` So that we don't need search `storedImages` if `forcePullImage` is true. - haosdent huang On March 15, 2016, 7:18 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44838/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 7:18 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4886 > https://issues.apache.org/jira/browse/MESOS-4886 > > > Repository: mesos > > > Description > ------- > > Enabled mesos containerizer force_pull_image for docker. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp > 137af502a66e6a65773c00eaacbe392576376284 > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp > cf630cc0b67a325529fa04ad2b1708e013b9596a > src/slave/containerizer/mesos/provisioner/docker/store.cpp > eeec94326a4fd67675df10e0b6a32267e555fa96 > > Diff: https://reviews.apache.org/r/44838/diff/ > > > Testing > ------- > > make > make check > > It is difficult to test this with unit test, but just test with mesos execute > by setting `force_pull_image` as true and found that the iamge was always > pulled when `force_pull_image` is true. > > > Thanks, > > Guangya Liu > >
