----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/#review116115 -----------------------------------------------------------
I am wondering if you do see performance issue regarding this? We typically don't optimize the code too much until it becomes a problem. Also, we try to avoid global variable dependencies (i.e., static bool isCreateError in this case). - Jie Yu On Jan. 13, 2016, 11:08 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41959/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 11:08 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Since fetcher plugins are not dynamically pluggable today, simplified the > factory method to use the statically intitalized plugins. This would be > useful when Fetchers are created multiple times. > > > Diffs > ----- > > src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b > > Diff: https://reviews.apache.org/r/41959/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
