----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111307 -----------------------------------------------------------
Ship it! LGTM , minus a query about using `model(...)` and not using the automated JSON to protbuf conversion. src/common/http.cpp (line 299) <https://reviews.apache.org/r/41423/#comment171422> Shouldn't this be: ``` object.values["container"] = std::move(task.container()); ``` src/common/http.cpp (line 405) <https://reviews.apache.org/r/41423/#comment171424> Ditto src/tests/containerizer/docker_containerizer_tests.cpp (line 473) <https://reviews.apache.org/r/41423/#comment171425> Newline before. src/tests/containerizer/docker_containerizer_tests.cpp (line 478) <https://reviews.apache.org/r/41423/#comment171427> Can we also check if the response was `200 OK` ? src/tests/containerizer/docker_containerizer_tests.cpp (line 489) <https://reviews.apache.org/r/41423/#comment171429> Ditto , check for `200 OK`. - Anand Mazumdar On Dec. 18, 2015, 11:12 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41423/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 11:12 p.m.) > > > Review request for mesos, Artem Harutyunyan and Jie Yu. > > > Bugs: MESOS-4064 > https://issues.apache.org/jira/browse/MESOS-4064 > > > Repository: mesos > > > Description > ------- > > Exposed partial contents of ContainerInfo through the state endpoint. > > > Diffs > ----- > > src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 > src/tests/containerizer/docker_containerizer_tests.cpp > 3f199e622dd337cdbf32d4368f4ead424c39823c > > Diff: https://reviews.apache.org/r/41423/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Artem Harutyunyan > >
