----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111221 -----------------------------------------------------------
Ship it! src/tests/containerizer/docker_containerizer_tests.cpp (line 474) <https://reviews.apache.org/r/41423/#comment171314> Looking at surrounding code, we're not using '{}' blocks. How about just reusing the variable name instead? src/tests/containerizer/docker_containerizer_tests.cpp (lines 506 - 510) <https://reviews.apache.org/r/41423/#comment171321> Maybe remove this in a followup patch? - Jie Yu On Dec. 17, 2015, 7:58 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41423/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 7:58 p.m.) > > > Review request for mesos, Artem Harutyunyan and Jie Yu. > > > Bugs: MESOS-4064 > https://issues.apache.org/jira/browse/MESOS-4064 > > > Repository: mesos > > > Description > ------- > > Exposed partial contents of ContainerInfo through the state endpoint. > > > Diffs > ----- > > src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 > src/tests/containerizer/docker_containerizer_tests.cpp > 3f199e622dd337cdbf32d4368f4ead424c39823c > > Diff: https://reviews.apache.org/r/41423/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Artem Harutyunyan > >
