----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/#review97910 -----------------------------------------------------------
I did not realize that we had a combined RR for this chain - please forgive my ignorance for now - I shall review the combined one once you fixed the locally mentioned issues. src/slave/containerizer/provisioners/docker.cpp (line 272) <https://reviews.apache.org/r/37200/#comment154007> One space indentation too many :) src/slave/containerizer/provisioners/docker/store.cpp (line 330) <https://reviews.apache.org/r/37200/#comment154013> One more space for the indentation. src/slave/containerizer/provisioners/docker/store.cpp (line 334) <https://reviews.apache.org/r/37200/#comment154017> How about checking for errors here? ``` const string path = path::join(staging, id, "rootfs"); Try<Nothing> mkdir = os::mkdir(path); if (mkdir.isError()) { return Error("Failed to create directory '" + path + "': " + mkdir.error()); } ``` src/slave/containerizer/provisioners/docker/store.cpp (line 384) <https://reviews.apache.org/r/37200/#comment154014> Repeat what? ... seems this comment needs adjustment or removal now that the previous comment, this one was referring to, got removed. src/slave/containerizer/provisioners/docker/store.cpp (line 397) <https://reviews.apache.org/r/37200/#comment154019> Error checking?! src/slave/containerizer/provisioners/docker/store.cpp (line 401) <https://reviews.apache.org/r/37200/#comment154018> Error checking?! - Till Toenshoff On Aug. 27, 2015, 11:41 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37200/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:41 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, > Timothy Chen, and Jiang Yan Xu. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Refactored DockerImage struct to store a list of layer ids instead of linked > list of DockerLayers. > > > Diffs > ----- > > src/slave/containerizer/provisioners/docker.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37200/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
