----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/#review96007 -----------------------------------------------------------
src/slave/containerizer/provisioners/docker.hpp (line 54) <https://reviews.apache.org/r/37200/#comment151201> I think I commented earlier, a remote registry might be part of the name with a ":" which specifies port. src/slave/containerizer/provisioners/docker/backend.cpp (line 127) <https://reviews.apache.org/r/37200/#comment151202> You can support a std::ostream& operator<< override for the ImageName src/slave/containerizer/provisioners/docker/store.cpp (line 130) <https://reviews.apache.org/r/37200/#comment151203> log the image name. src/slave/containerizer/provisioners/docker/store.cpp (line 134) <https://reviews.apache.org/r/37200/#comment151204> I think we want to create a staging directory underneath a set staging directory, simialiar how appc does it. src/slave/containerizer/provisioners/docker/store.cpp (line 402) <https://reviews.apache.org/r/37200/#comment151205> Use os::rename() instead of calling mv yourself - Timothy Chen On Aug. 19, 2015, 6:44 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37200/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 6:44 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, > and Jiang Yan Xu. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Refactored DockerImage struct to store a list of layer ids instead of linked > list of DockerLayers. > > > Diffs > ----- > > src/slave/containerizer/provisioners/docker.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37200/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
