> On Aug. 13, 2015, 9:39 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/appc/spec.hpp, lines 41-42 > > <https://reviews.apache.org/r/37310/diff/4/?file=1039588#file1039588line41> > > > > We wrap comments in 70 char width. Please make sure this is the case:) > > Jiang Yan Xu wrote: > I adjusted the line wrapping due to the discussion here: > http://www.mail-archive.com/[email protected]/msg33053.html, which I > support. What do you think? We should of course make it official on the style > guide.
Then we should at least make it less jagged. This particular comment is very jagged (with only one word in the next line). - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37310/#review95333 ----------------------------------------------------------- On Aug. 13, 2015, 9:33 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37310/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 9:33 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added Appc spec validation utility. > > > Diffs > ----- > > src/Makefile.am 942003149b071a322933e2c085d9122903f69713 > src/slave/containerizer/provisioners/appc/spec.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc/spec.cpp PRE-CREATION > src/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37310/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
