----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37310/#review94986 -----------------------------------------------------------
src/slave/containerizer/provisioners/appc/spec.hpp (line 38) <https://reviews.apache.org/r/37310/#comment149734> We usually return Option<Error> for validation functions (see master validation) so that None() means no error and Some() means there's some error. src/slave/containerizer/provisioners/appc/spec.hpp (line 39) <https://reviews.apache.org/r/37310/#comment149736> We try to speed up the compliation. Could you please move the implementation to the cpp file and add some comments about each method in the header? src/tests/containerizer/appc_provisioner_tests.cpp (line 75) <https://reviews.apache.org/r/37310/#comment149731> Add one blank line above. src/tests/containerizer/appc_provisioner_tests.cpp (line 84) <https://reviews.apache.org/r/37310/#comment149730> Add one blank line above. - Jie Yu On Aug. 10, 2015, 7:18 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37310/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 7:18 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added Appc spec validation utility. > > > Diffs > ----- > > src/Makefile.am 942003149b071a322933e2c085d9122903f69713 > src/slave/containerizer/provisioners/appc/spec.hpp PRE-CREATION > src/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37310/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
