----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review95240 -----------------------------------------------------------
Ship it! Looks good modulo minor fixes. I'll fix them and commit for you. src/scheduler/scheduler.cpp (line 329) <https://reviews.apache.org/r/37303/#comment150090> indentation. src/scheduler/scheduler.cpp (line 393) <https://reviews.apache.org/r/37303/#comment150091> No comment here? src/scheduler/scheduler.cpp (line 412) <https://reviews.apache.org/r/37303/#comment150092> indentation. - Vinod Kone On Aug. 13, 2015, 5:39 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37303/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 5:39 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-2552 > https://issues.apache.org/jira/browse/MESOS-2552 > > > Repository: mesos > > > Description > ------- > > This changes moves scheduler library to http. The change to remove auth + > install,receive handlers are in other reviews. > > > Diffs > ----- > > src/common/http.hpp 98a12709ae5fcbf4ce3e37d164bff43818096838 > src/scheduler/scheduler.cpp 3fbe3831cf93c29180bc7e433fd57c6108988316 > > Diff: https://reviews.apache.org/r/37303/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
