----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review95226 -----------------------------------------------------------
src/common/http.hpp (line 51) <https://reviews.apache.org/r/37303/#comment150063> kill this. src/scheduler/scheduler.cpp (line 257) <https://reviews.apache.org/r/37303/#comment150077> make sure to close the http connection here to avoid accidentally sending non-subscribe calls to a new master. src/scheduler/scheduler.cpp (line 321) <https://reviews.apache.org/r/37303/#comment150064> add a comment on when this is possible. src/scheduler/scheduler.cpp (line 342) <https://reviews.apache.org/r/37303/#comment150066> s/keepReading/read/ src/scheduler/scheduler.cpp (line 351) <https://reviews.apache.org/r/37303/#comment150067> s/a/unexpected/ src/scheduler/scheduler.cpp (line 353) <https://reviews.apache.org/r/37303/#comment150074> when can we get here? can you add a comment? per our disccussion, this should call error()? src/scheduler/scheduler.cpp (line 359) <https://reviews.apache.org/r/37303/#comment150078> indentation. src/scheduler/scheduler.cpp (line 365) <https://reviews.apache.org/r/37303/#comment150068> s/oldReader/reader/ src/scheduler/scheduler.cpp (line 383) <https://reviews.apache.org/r/37303/#comment150069> this could happen during master failover too. so let's not send an error() src/scheduler/scheduler.cpp (line 396) <https://reviews.apache.org/r/37303/#comment150071> indent by 2 spaces. s/WARNING/ERROR/ this should call error(). - Vinod Kone On Aug. 12, 2015, 10:26 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37303/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 10:26 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-2552 > https://issues.apache.org/jira/browse/MESOS-2552 > > > Repository: mesos > > > Description > ------- > > This changes moves scheduler library to http. The change to remove auth + > install,receive handlers are in other reviews. > > > Diffs > ----- > > src/common/http.hpp 98a12709ae5fcbf4ce3e37d164bff43818096838 > src/scheduler/scheduler.cpp 3fbe3831cf93c29180bc7e433fd57c6108988316 > > Diff: https://reviews.apache.org/r/37303/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
