> On July 16, 2015, 6:52 p.m., Vinod Kone wrote: > > src/sched/sched.cpp, lines 494-495 > > <https://reviews.apache.org/r/36498/diff/1/?file=1011994#file1011994line494> > > > > couldn't you have used ANY which is the default?
I only want to remove from the front and the end, ANY will remove from anywhere in the string. I'll use strings::trim instead, where ANY means front and back as you expected (although ANY is a bit confusing in this context :)). - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/#review91939 ----------------------------------------------------------- On July 15, 2015, 1:47 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36498/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 1:47 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2910 and MESOS-3012 > https://issues.apache.org/jira/browse/MESOS-2910 > https://issues.apache.org/jira/browse/MESOS-3012 > > > Repository: mesos > > > Description > ------- > > This relies on 'Offer.url' to compute the pids needed for the message passing > optimization (see > [MESOS-3012](https://issues.apache.org/jira/browse/MESOS-3012)). > > > Diffs > ----- > > src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f > src/tests/scheduler_event_call_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36498/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Ben Mahler > >
