----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/#review91939 -----------------------------------------------------------
Ship it! src/sched/sched.cpp (lines 494 - 495) <https://reviews.apache.org/r/36498/#comment145685> couldn't you have used ANY which is the default? src/tests/scheduler_event_call_tests.cpp (line 176) <https://reviews.apache.org/r/36498/#comment145691> This test also ensures that framework to executor messages can bypass the master right? Mind adding that here? src/tests/scheduler_event_call_tests.cpp (line 211) <https://reviews.apache.org/r/36498/#comment145693> s/offers/ResourceOfferMessages/ src/tests/scheduler_event_call_tests.cpp (lines 230 - 235) <https://reviews.apache.org/r/36498/#comment145694> use createTask()? src/tests/scheduler_event_call_tests.cpp (line 237) <https://reviews.apache.org/r/36498/#comment145695> Why capture the executor driver when it's not used? - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36498/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 1:47 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2910 and MESOS-3012 > https://issues.apache.org/jira/browse/MESOS-2910 > https://issues.apache.org/jira/browse/MESOS-3012 > > > Repository: mesos > > > Description > ------- > > This relies on 'Offer.url' to compute the pids needed for the message passing > optimization (see > [MESOS-3012](https://issues.apache.org/jira/browse/MESOS-3012)). > > > Diffs > ----- > > src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f > src/tests/scheduler_event_call_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36498/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Ben Mahler > >
