> On July 15, 2015, 4:16 a.m., haosdent huang wrote: > > src/tests/utils.hpp, line 55 > > <https://reviews.apache.org/r/36501/diff/1/?file=1012134#file1012134line55> > > > > The code styple need change to follow > > https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md
I've read this code style guidance and updated code accordingly :). Thanks very much for your comments. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review91706 ----------------------------------------------------------- On July 16, 2015, 5:47 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36501/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 5:47 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-3023 > https://issues.apache.org/jira/browse/MESOS-3023 > > > Repository: mesos > > > Description > ------- > > Fix for MESOS-3023 (Factoring out the pattern for URL generation) > > > Diffs > ----- > > src/tests/fetcher_tests.cpp ae10c42 > src/tests/utils.hpp f2eed2e > > Diff: https://reviews.apache.org/r/36501/diff/ > > > Testing > ------- > > 1. Build successfully in Linux > 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest > > > Thanks, > > Klaus Ma > >
