----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review91706 -----------------------------------------------------------
src/tests/utils.hpp (line 26) <https://reviews.apache.org/r/36501/#comment145266> why not use methods in <string>? src/tests/utils.hpp (line 54) <https://reviews.apache.org/r/36501/#comment145265> I suggest move the implement to cpp file. src/tests/utils.hpp (line 55) <https://reviews.apache.org/r/36501/#comment145267> The code styple need change to follow https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md src/tests/utils.hpp (line 56) <https://reviews.apache.org/r/36501/#comment145268> - haosdent huang On July 15, 2015, 2:59 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36501/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 2:59 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-3023 > https://issues.apache.org/jira/browse/MESOS-3023 > > > Repository: mesos > > > Description > ------- > > Fix for MESOS-3023 (Factoring out the pattern for URL generation) > > > Diffs > ----- > > src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 > src/tests/utils.hpp f2eed2e6fbc2cc8772c642bba976b25b426784e8 > > Diff: https://reviews.apache.org/r/36501/diff/ > > > Testing > ------- > > 1. Build successfully in Linux > 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest > > > Thanks, > > Klaus Ma > >
