> On June 25, 2015, 5:20 p.m., Isabel Jimenez wrote: > > src/scheduler/scheduler.cpp, line 306 > > <https://reviews.apache.org/r/35858/diff/1/?file=991724#file991724line306> > > > > Now that we're sending calls in every case (besides SUBSCRIBE) of this > > switch, I suppose it'll be better to move this to the end and maybe test > > just for SUBSCRIBE outside the switch?
i tried doing that but felt this was more readable, especially for cases like TEARDOWN which doesn't have any logic in the case statement. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35858/#review89384 ----------------------------------------------------------- On July 1, 2015, 5:26 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35858/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 5:26 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and > Marco Massenzio. > > > Bugs: MESOS-2551 > https://issues.apache.org/jira/browse/MESOS-2551 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 > src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 > src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6 > src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f > > Diff: https://reviews.apache.org/r/35858/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
