> On June 25, 2015, 4:35 p.m., Anand Mazumdar wrote: > > src/master/master.cpp, line 3139 > > <https://reviews.apache.org/r/35858/diff/1/?file=991723#file991723line3139> > > > > I had a general query regarding pre-pending the function arguments with > > _ in our style guide. Here we do the opposite i.e. use a trailing > > underscore. Are both allowed or is it preferred to use the one from the > > style guide ?
We've gone with prefix _ for parameters to constructors or functions so that we can avoid shadowing variable names. Ultimately we're trying to reserve suffix _ for member fields, ala Google Style, but we've used suffix _ for naming variables as though they're "prime", i.e., 'message_' here reads "message prime". Ultimately we should just use suffix _ for member fields. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35858/#review89371 ----------------------------------------------------------- On June 25, 2015, 12:31 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35858/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 12:31 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and > Marco Massenzio. > > > Bugs: MESOS-2551 > https://issues.apache.org/jira/browse/MESOS-2551 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 > src/master/master.cpp 0782b543b451921d2240958c7ef612a9e30972df > src/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b > src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f > > Diff: https://reviews.apache.org/r/35858/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
