----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review89430 -----------------------------------------------------------
src/messages/messages.proto (line 336) <https://reviews.apache.org/r/35721/#comment142037> Why do you need to pass the user through CheckpointResourcesMessage. Slave should already keep track of FrameworkInfo for each live framework. src/slave/slave.cpp (lines 2153 - 2157) <https://reviews.apache.org/r/35721/#comment142039> Ditto Adam's comment on switch_user. Also, what if the user specifies a user in CommandInfo. The current semantics is that the executor will be launched under that user. See https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L4633 I think the owner/group of a persistent volume should be the same as the sandbox directory. So probably you can chown whenever you link the volumes (see updateVolumes in MesosContainerizer, which soon will be moved to a posix filesystem isolator https://reviews.apache.org/r/34135/) and sync that with the sandbox owner/group. - Jie Yu On June 22, 2015, 1:56 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35721/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 1:56 a.m.) > > > Review request for mesos, Adam B and Jie Yu. > > > Bugs: MESOS-2603 > https://issues.apache.org/jira/browse/MESOS-2603 > > > Repository: mesos > > > Description > ------- > > Set the owner of persistent volumes to frameworkInfo.user . > > > Diffs > ----- > > src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d > src/messages/messages.proto 1c8d79e3fca365520cdd67051f8730593955cab6 > src/slave/slave.hpp f1cf3b85ccb3eaf614fe844c830f7cc44f7916fe > src/slave/slave.cpp 40c0c33add392591af4767f76ce566196f24e6ee > > Diff: https://reviews.apache.org/r/35721/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
