----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34427/#review84386 -----------------------------------------------------------
Bad patch! Reviews applied: [34136, 34134, 34135, 34134] Failed command: ./support/apply-review.sh -n -r 34134 Error: 2015-05-19 20:54:21 URL:https://reviews.apache.org/r/34134/diff/raw/ [18243/18243] -> "34134.patch" [1] error: patch failed: include/mesos/slave/isolator.hpp:98 error: include/mesos/slave/isolator.hpp: patch does not apply error: patch failed: src/slave/containerizer/isolator.cpp:57 error: src/slave/containerizer/isolator.cpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/cgroups/cpushare.hpp:48 error: src/slave/containerizer/isolators/cgroups/cpushare.hpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/cgroups/cpushare.cpp:261 error: src/slave/containerizer/isolators/cgroups/cpushare.cpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/cgroups/mem.hpp:48 error: src/slave/containerizer/isolators/cgroups/mem.hpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/cgroups/mem.cpp:240 error: src/slave/containerizer/isolators/cgroups/mem.cpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/cgroups/perf_event.hpp:46 error: src/slave/containerizer/isolators/cgroups/perf_event.hpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/cgroups/perf_event.cpp:225 error: src/slave/containerizer/isolators/cgroups/perf_event.cpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/filesystem/shared.hpp:47 error: src/slave/containerizer/isolators/filesystem/shared.hpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/filesystem/shared.cpp:76 error: src/slave/containerizer/isolators/filesystem/shared.cpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/namespaces/pid.hpp:64 error: src/slave/containerizer/isolators/namespaces/pid.hpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/namespaces/pid.cpp:157 error: src/slave/containerizer/isolators/namespaces/pid.cpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/posix.hpp:66 error: src/slave/containerizer/isolators/posix.hpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/posix/disk.hpp:85 error: src/slave/containerizer/isolators/posix/disk.hpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/posix/disk.cpp:105 error: src/slave/containerizer/isolators/posix/disk.cpp: patch does not apply error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:609 error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply error: patch failed: src/tests/containerizer_tests.cpp:73 error: src/tests/containerizer_tests.cpp: patch does not apply error: patch failed: src/tests/isolator.hpp:45 error: src/tests/isolator.hpp: patch does not apply error: patch failed: src/tests/isolator_tests.cpp:171 error: src/tests/isolator_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May 19, 2015, 6:46 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34427/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 6:46 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Note: This is a specialized backend; see notes in bind_backend.hpp. > > Reproduced here for your convenience: > > This is a specialized backend that may be useful for deployments > using large (multi-GB) single-layer images *and* where more > recent kernel features such as overlayfs are not available. For small > images (10's to 100's of MB) the Copy backend may be sufficient. > 1) It supports only a single layer. Multi-layer images will fail > to provision and the container will fail to launch! > 2) The filesystem is read-only because all containers using this > image share the source. Select writable areas can be achieved > by > mounting read-write volumes to places like /tmp, /var/tmp, > /home, etc. using the ContainerInfo. These can be relative to > the executor work directory. > 3) It relies on the image persisting in the store. > 4) It's fast because the bind mount requires (nearly) zero IO. > > > Diffs > ----- > > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > src/slave/containerizer/provisioners/appc/backend.cpp PRE-CREATION > src/slave/containerizer/provisioners/appc/bind_backend.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34427/diff/ > > > Testing > ------- > > manual testing of a single layer image with RW relative bind mount for /tmp. > > > Thanks, > > Ian Downes > >
