----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309/#review84234 -----------------------------------------------------------
Hey Ian, looks good. I have a prototype for testing the pre-emption. I will add some reviews that depend on this patch set, as I will need to introduce sched_affinity first. src/linux/sched.hpp <https://reviews.apache.org/r/34309/#comment135393> Would this be easier to read if we flipped the logic? ``` if ((policy != FIFO && policy != RR) && priority != 0) { ``` Feel free to ignore, either way works :-) - Joris Van Remoortere On May 18, 2015, 8:48 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34309/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 8:48 p.m.) > > > Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-2652 > https://issues.apache.org/jira/browse/MESOS-2652 > > > Repository: mesos > > > Description > ------- > > Support manipulating scheduler policy on Linux. > > > Diffs > ----- > > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > src/linux/sched.hpp PRE-CREATION > src/tests/sched_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34309/diff/ > > > Testing > ------- > > Added test. > > > Thanks, > > Ian Downes > >
