----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309/#review84331 -----------------------------------------------------------
src/linux/sched.hpp <https://reviews.apache.org/r/34309/#comment135541> Do we need to have a global invariant, that this isn't included on mac? src/linux/sched.hpp <https://reviews.apache.org/r/34309/#comment135543> Does it make sense to const this? src/linux/sched.hpp <https://reviews.apache.org/r/34309/#comment135545> Want to add some context to which pid that you couldn't get the policy for? For example: "Failed to get scheduler policy for pid: 1234" src/linux/sched.hpp <https://reviews.apache.org/r/34309/#comment135547> How about adding the pid here? :) src/linux/sched.hpp <https://reviews.apache.org/r/34309/#comment135548> Same here src/tests/sched_tests.cpp <https://reviews.apache.org/r/34309/#comment135551> Can you go in a bit more detail about what this test does? What is the point of starting the children and having them sleep and change the parent sched policy? src/tests/sched_tests.cpp <https://reviews.apache.org/r/34309/#comment135552> Any reason not to use the fork abstraction? If not, want to explicitly use ::fork()? src/tests/sched_tests.cpp <https://reviews.apache.org/r/34309/#comment135553> Do you want a return here, to make sure the children doesn't continue into the parent code? src/tests/sched_tests.cpp <https://reviews.apache.org/r/34309/#comment135554> It would be great to have a reap abstraction, so we don't have to fiddle too much with the masked types. Could we have used the reaper? - Niklas Nielsen On May 18, 2015, 1:48 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34309/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 1:48 p.m.) > > > Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-2652 > https://issues.apache.org/jira/browse/MESOS-2652 > > > Repository: mesos > > > Description > ------- > > Support manipulating scheduler policy on Linux. > > > Diffs > ----- > > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > src/linux/sched.hpp PRE-CREATION > src/tests/sched_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34309/diff/ > > > Testing > ------- > > Added test. > > > Thanks, > > Ian Downes > >
