[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20487 )
Change subject: IMPALA-12399: (addendum) Fixed possible deadloop and also do not set the event skip list in notification request to update latestEventId_ ...................................................................... Patch Set 4: (3 comments) Reworked for comments http://gerrit.cloudera.org:8080/#/c/20487/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20487/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@937 PS2, Line 937: public void updateLatestEventId() { > I realized that we don't want to filter out any event types here since we a Done http://gerrit.cloudera.org:8080/#/c/20487/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1052 PS2, Line 1052: * Process the given list of notification events. Useful for tests which provide a list > We also need to update lastSyncedEventId_ if 'events' is empty now. Done http://gerrit.cloudera.org:8080/#/c/20487/2/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20487/2/tests/custom_cluster/test_events_custom_configs.py@610 PS2, Line 610: > Can we add a new test here firing an OPEN_TXN event and verify the event pr Have added test to verify latestEventId_ and lastSyncedEventId_ in MetastoreEventsProcessor. -- To view, visit http://gerrit.cloudera.org:8080/20487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb4b8c3db23d39226f10b33cca4e6a1ab271b925 Gerrit-Change-Number: 20487 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2023 07:02:43 +0000 Gerrit-HasComments: Yes
