[email protected] has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20487 )
Change subject: IMPALA-12399: (addendum) Fixed possible deadloop and also do not set the event skip list in notification request to update latestEventId_ ...................................................................... IMPALA-12399: (addendum) Fixed possible deadloop and also do not set the event skip list in notification request to update latestEventId_ Following points are fixed: 1. Possible deadloop in MetastoreEventsProcessor#getNextMetastoreEventsInBatches() when OPEN_TXN is the last event on HMS at the moment the method is invoked. Need to return when events received in response is empty. 2. latestEventId_ reflects the latest event in HMS. Should not set the event skip list in notification request to update latestEventId_. 3. Update lastSyncedEventId_ when event list returned is empty due to event skip list in notification event. Testing: - Added tests and executed all existing tests. Change-Id: Idb4b8c3db23d39226f10b33cca4e6a1ab271b925 --- M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 4 files changed, 150 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/20487/4 -- To view, visit http://gerrit.cloudera.org:8080/20487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb4b8c3db23d39226f10b33cca4e6a1ab271b925 Gerrit-Change-Number: 20487 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
