Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24140 )
Change subject: IMPALA-14859: Fix crashes in parquet-column-chunk-reader.cc ...................................................................... IMPALA-14859: Fix crashes in parquet-column-chunk-reader.cc If running out of memory when trying to uncompress dictionary page buffer during parquet read, there was a crash, because there was an assumption that dict_page_pool_ failed to allocate it, but dict_page_pool_ is not initialized in this case, so there is a nullptr dereference. The error was fixed by only referencing dict_page_pool_ in the path where it is valid, and reverting the other path to reference parent's dictionary_pool_, which always exists. The error was introduced in IMPALA-14794 with commit 49f0ab1d09541f960cee12e9a5e6aa38ec21565a Change-Id: I7e6b4e17c627baf97dee04cdfb9c63cdc0dad3b5 Reviewed-on: http://gerrit.cloudera.org:8080/24140 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Csaba Ringhofer <[email protected]> --- M be/src/exec/parquet/parquet-column-chunk-reader.cc 1 file changed, 15 insertions(+), 7 deletions(-) Approvals: Impala Public Jenkins: Verified Csaba Ringhofer: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7e6b4e17c627baf97dee04cdfb9c63cdc0dad3b5 Gerrit-Change-Number: 24140 Gerrit-PatchSet: 7 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
