Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24140 )
Change subject: IMPALA-14859: Fix crashes in parquet-column-chunk-reader.cc ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24140/3/be/src/exec/parquet/parquet-column-chunk-reader.cc File be/src/exec/parquet/parquet-column-chunk-reader.cc: http://gerrit.cloudera.org:8080/#/c/24140/3/be/src/exec/parquet/parquet-column-chunk-reader.cc@190 PS3, Line 190: } else { : if (LIKELY(uncompressed_buffer->TryAllocate(buff > I think it would be cleaner to move the error handling closer to where the Done -- To view, visit http://gerrit.cloudera.org:8080/24140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e6b4e17c627baf97dee04cdfb9c63cdc0dad3b5 Gerrit-Change-Number: 24140 Gerrit-PatchSet: 4 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 26 Mar 2026 18:16:06 +0000 Gerrit-HasComments: Yes
