Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23912 )
Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters ...................................................................... Patch Set 8: (4 comments) The code has been changed based on the suggestions made in IMPALA-14436. http://gerrit.cloudera.org:8080/#/c/23912/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23912/7//COMMIT_MSG@9 PS7, Line 9: This patch fixes an issue where min/max runtime filters were not getting : created for nested loop joins. The conju > I don't understand what the optimization does. What original Impala test ca Addressed in general comment http://gerrit.cloudera.org:8080/#/c/23912/7//COMMIT_MSG@18 PS7, Line 18: : An extra minor fix h > Is this still true? I'm not seeing a difference other than conjuncts vs joi Comment changed http://gerrit.cloudera.org:8080/#/c/23912/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java: http://gerrit.cloudera.org:8080/#/c/23912/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@567 PS7, Line 567: private static class > Can there be a limit 1 on HDFSSCAN nodes? code removed http://gerrit.cloudera.org:8080/#/c/23912/7/testdata/workloads/functional-query/queries/QueryTest/calcite.test File testdata/workloads/functional-query/queries/QueryTest/calcite.test: http://gerrit.cloudera.org:8080/#/c/23912/7/testdata/workloads/functional-query/queries/QueryTest/calcite.test@1263 PS7, Line 1263: : > If I put this in Impala, I get the same plan whether this is limit 1 or lim Test removed. This is gonna be tested in the Jenkins run for overlap_min_max_filters.test so a new test is not needed. The test fails without this patch. -- To view, visit http://gerrit.cloudera.org:8080/23912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755 Gerrit-Change-Number: 23912 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 07 Mar 2026 23:21:42 +0000 Gerrit-HasComments: Yes
