Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23912
to look at the new patch set (#8).
Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
......................................................................
IMPALA-14436: Calcite planner: Fix min/max runtime filters
This patch fixes an issue where min/max runtime filters were not getting
created for nested loop joins. The conjuncts need to be placed in
the right variables when initializing the NestedLoopJoinNode.
For inner joins, all the conjuncts need to be in the filterConjuncts
in order to be processed for the min/max runtime filter.
This patch is needed to allow overlap_min_max_filters.test to succeed
for the Calcite planner.
An extra minor fix has been thrown into the patch: When the conjunct
is "IS NOT DISCTINCT FROM", this should be treated as an equi-join
conjunct.
Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
---
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaNestedLoopJoinNode.java
M
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
M
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
M
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
M
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
M
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
M
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
M
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
10 files changed, 119 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/23912/8
--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
