Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24062 )
Change subject: IMPALA-14116: Skip NULL in IN-list against a string column of ORC table ...................................................................... Patch Set 7: (1 comment) I have addressed the comment on patch set 5. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/24062/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/24062/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@687 PS5, Line 687: it to > I think we can simply skip this child since NULL items in the in-list are i Thanks for pointing this out Quanlong! I will revise the patch accordingly in the next patch set. -- To view, visit http://gerrit.cloudera.org:8080/24062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id62a631e5aa97132afbe0b184d427ad6bc1a4ad0 Gerrit-Change-Number: 24062 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2026 19:17:33 +0000 Gerrit-HasComments: Yes
