Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24062 )
Change subject: IMPALA-14116: [WIP] Do not push down NULL in IN-list against a string column of ORC table ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/24062/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/24062/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@687 PS5, Line 687: return I think we can simply skip this child since NULL items in the in-list are ignored. https://stackoverflow.com/questions/6362112/in-clause-with-null-or-is-null I.e., changing "return" to "continue". -- To view, visit http://gerrit.cloudera.org:8080/24062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id62a631e5aa97132afbe0b184d427ad6bc1a4ad0 Gerrit-Change-Number: 24062 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2026 05:20:50 +0000 Gerrit-HasComments: Yes
