Hello Jason Fehr, Pranav Lodha, Csaba Ringhofer, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23499

to look at the new patch set (#27).

Change subject: IMPALA-14460: Implement connect_timeout_ms for HS2-HTTP
......................................................................

IMPALA-14460: Implement connect_timeout_ms for HS2-HTTP

Implements connect_timeout_ms support for HS2-HTTP. This only applies
the timeout while establishing the connection, so later requests do not
timeout. This is preferrable to configuring http_socket_timeout_s, which
can result in timing out operations that just take awhile to execute.

Switches internal tracking of http_socket_timeout_s to
http_socket_timeout_ms because the setTimeout method we use to update
timeout after a connection is established expects milliseconds.

Testing:
- updates tests now that HS2-HTTP supports connect_timeout_ms.
- test_impala_shell_timeout for HS2-HTTP without http_socket_timeout_s

Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2
---
M shell/impala_shell/ImpalaHttpClient.py
M shell/impala_shell/impala_client.py
M shell/impala_shell/impala_shell.py
M tests/shell/test_shell_commandline.py
4 files changed, 38 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23499/27
--
To view, visit http://gerrit.cloudera.org:8080/23499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2
Gerrit-Change-Number: 23499
Gerrit-PatchSet: 27
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>

Reply via email to