Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23499 )
Change subject: IMPALA-14460: Implement connect_timeout_ms for HS2-HTTP ...................................................................... Patch Set 26: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23499/26/shell/impala_shell/impala_client.py File shell/impala_shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/23499/26/shell/impala_shell/impala_client.py@478 PS26, Line 478: # After connecting, set http_socket_timeout_ms for the remainder of the session. : transportImpl.setTimeout(self.http_socket_timeout_ms) Wouldn't it make more sense to move this inside ImpalaHttpClient.open()? The idea is to always set the timeout initially but resetting it to 0 after open self.__http.connect() This would lead a to a very different behavior, as currently each rpc creates a new connection, so each would use timeout when creating the TCP connections, and then revert to 0 during the actual RPC. I think that this is preferable, as network issue can occur during the lifetime of a session. With https://gerrit.cloudera.org/#/c/23831/ reconnections would be much less frequent, but when it actually happens (e.g. the connection was reset between RPCs), then it makes sense to me to use the timeout again. -- To view, visit http://gerrit.cloudera.org:8080/23499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2 Gerrit-Change-Number: 23499 Gerrit-PatchSet: 26 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Thu, 08 Jan 2026 09:32:39 +0000 Gerrit-HasComments: Yes
