Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23810 )
Change subject: IMPALA-14647: Fix truncate for replicated txn tables always delete data ...................................................................... Patch Set 1: (1 comment) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/23810/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23810/1//COMMIT_MSG@14 PS1, Line 14: In HiveServer, there is a configuration, "hive.acid.truncate.usebase", > I would also consider always calling the HMS API to ensure that things work > the same way in replicated/non-replicated cases. Yeah, we only implemented our createEmptyBaseDirectories() for TRUNCATE because in the past Hive's TRUNCATE always removed the files. I don't think we should a new query option for this without any actual need from users. I think for now it's OK if Impala only uses the HiveConf "hive.acid.truncate.usebase" parameter and keeps files by default. -- To view, visit http://gerrit.cloudera.org:8080/23810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia31991baeb2ef8717c387b841b65cff562dbcae0 Gerrit-Change-Number: 23810 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Jan 2026 15:05:55 +0000 Gerrit-HasComments: Yes
